aboutsummaryrefslogtreecommitdiff
path: root/qtmips_gui/cacheview.cpp
diff options
context:
space:
mode:
authorPavel Pisa <pisa@cmp.felk.cvut.cz>2019-03-17 00:28:01 +0100
committerPavel Pisa <pisa@cmp.felk.cvut.cz>2019-03-17 00:28:01 +0100
commit8b5298566773275b5c8423dace3396a325f38541 (patch)
treeec0a2fb675ad69beb992e7679849d609b7d91325 /qtmips_gui/cacheview.cpp
parent80cbe0dce0cb950a05a3221f612946364a25a198 (diff)
downloadqtmips-8b5298566773275b5c8423dace3396a325f38541.tar.gz
qtmips-8b5298566773275b5c8423dace3396a325f38541.tar.bz2
qtmips-8b5298566773275b5c8423dace3396a325f38541.zip
Correct word in block visualization in cache view.
The word index (column) has been erroneously used for set index value. Signed-off-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Diffstat (limited to 'qtmips_gui/cacheview.cpp')
-rw-r--r--qtmips_gui/cacheview.cpp15
1 files changed, 9 insertions, 6 deletions
diff --git a/qtmips_gui/cacheview.cpp b/qtmips_gui/cacheview.cpp
index b246102..6eb1bfe 100644
--- a/qtmips_gui/cacheview.cpp
+++ b/qtmips_gui/cacheview.cpp
@@ -59,7 +59,8 @@ CacheAddressBlock::CacheAddressBlock(const machine::Cache *cache, unsigned width
row = 0;
col = 0;
- connect(cache, SIGNAL(cache_update(uint,uint,bool,bool,std::uint32_t,const std::uint32_t*)), this, SLOT(cache_update(uint,uint,bool,bool,std::uint32_t,const std::uint32_t*)));
+ connect(cache, SIGNAL(cache_update(uint,uint,uint,bool,bool,std::uint32_t,const std::uint32_t*)),
+ this, SLOT(cache_update(uint,uint,uint,bool,bool,std::uint32_t,const std::uint32_t*)));
}
QRectF CacheAddressBlock::boundingRect() const {
@@ -130,10 +131,10 @@ void CacheAddressBlock::paint(QPainter *painter, const QStyleOptionGraphicsItem
}
}
-void CacheAddressBlock::cache_update(unsigned associat, unsigned set, bool valid, bool dirty, std::uint32_t tag, const std::uint32_t *data) {
+void CacheAddressBlock::cache_update(unsigned associat, unsigned set, unsigned col, bool valid, bool dirty, std::uint32_t tag, const std::uint32_t *data) {
this->tag = tag;
- this->row = 0; // TODO we are missing this information
- this->col = set;
+ this->row = set;
+ this->col = col;
update();
}
@@ -207,7 +208,8 @@ CacheViewBlock::CacheViewBlock(const machine::Cache *cache, unsigned block , boo
box = l_data->boundingRect();
l_data->setPos(wd + (columns*DATA_WIDTH - box.width())/2 , -1 - box.height());
- connect(cache, SIGNAL(cache_update(uint,uint,bool,bool,std::uint32_t,const std::uint32_t*)), this, SLOT(cache_update(uint,uint,bool,bool,std::uint32_t,const std::uint32_t*)));
+ connect(cache, SIGNAL(cache_update(uint,uint,uint,bool,bool,std::uint32_t,const std::uint32_t*)),
+ this, SLOT(cache_update(uint,uint,uint,bool,bool,std::uint32_t,const std::uint32_t*)));
}
CacheViewBlock::~CacheViewBlock() {
@@ -325,7 +327,8 @@ void CacheViewBlock::paint(QPainter *painter, const QStyleOptionGraphicsItem *op
}
}
-void CacheViewBlock::cache_update(unsigned associat, unsigned set, bool valid, bool dirty, std::uint32_t tag, const std::uint32_t *data) {
+void CacheViewBlock::cache_update(unsigned associat, unsigned set, unsigned col, bool valid, bool dirty, std::uint32_t tag, const std::uint32_t *data) {
+ (void)col;
if (associat != block)
return; // Ignore blocks that are not us
validity[set]->setText(valid ? "1" : "0");