From d7d9860051a9a9eb2c6f11684535ac65cce38eb8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Karel=20Ko=C4=8D=C3=AD?= Date: Mon, 15 Jan 2018 15:22:44 +0100 Subject: Cleanup some todos in code --- qtmips_machine/tests/testinstruction.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'qtmips_machine/tests') diff --git a/qtmips_machine/tests/testinstruction.cpp b/qtmips_machine/tests/testinstruction.cpp index 2cdf119..37fdd10 100644 --- a/qtmips_machine/tests/testinstruction.cpp +++ b/qtmips_machine/tests/testinstruction.cpp @@ -5,10 +5,10 @@ using namespace machine; // Test that we are correctly encoding instructions in constructor void MachineTests::instruction() { - QCOMPARE(Instruction(0x00), Instruction(0,0)); + QCOMPARE(Instruction(0x0), Instruction()); + QCOMPARE(Instruction(0x4432146), Instruction(1, 2, 3, 4, 5, 6)); + QCOMPARE(Instruction(0x4430004), Instruction(1, 2, 3, 4)); QCOMPARE(Instruction(0x4000002), Instruction(1, 2)); - // QCOMPARE(Instruction(0x4000002), Instruction(1, 2, 3, 4)); - // TODO other combinations } // Test that we are correctly decoding instruction fields @@ -25,3 +25,5 @@ void MachineTests::instruction_access() { QCOMPARE(i.immediate(), (std::uint16_t) 0xffff); QCOMPARE(i.address(), (std::uint32_t) 0x3ffffff); } + +// TODO test to_str -- cgit v1.2.3