From 8eaf6c4734e1184d7c31708247cba0fa01999386 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Karel=20Ko=C4=8D=C3=AD?= <cynerd@email.cz>
Date: Tue, 9 Aug 2022 20:15:23 +0200
Subject: common.sh: fix invalid switch

---
 common.sh | 34 +++++++++++++++++++++++++---------
 1 file changed, 25 insertions(+), 9 deletions(-)

(limited to 'common.sh')

diff --git a/common.sh b/common.sh
index 995a57e..4f005de 100644
--- a/common.sh
+++ b/common.sh
@@ -35,16 +35,31 @@ sshdest() {
 	awk -F- 'NF > 1 { print $2"."$1; exit } { print $1 }' <<<"$1"
 }
 
+_sh() {
+	if [ $# -gt 1 ]; then
+		"$@"
+	else
+		sh -c "$1"
+	fi
+}
+
 _ssh() {
 	local device="$1"
 	shift
 	if [ "$device" != "$(hostname)" ]; then
-		local -a args
-		[ "$1" = "sudo" ] && \
-			args+=('-t') # Crude detection for terminal need
-		ssh "${args[@]}" "$(sshdest "$device")" -- "$@"
+		ssh "$(sshdest "$device")" -- "$@"
 	else
-		"$@"
+		_sh "$@"
+	fi
+}
+
+_tssh() {
+	local device="$1"
+	shift
+	if [ "$device" != "$(hostname)" ]; then
+		ssh -t "$(sshdest "$device")" -- "$@"
+	else
+		_sh "$@"
 	fi
 }
 
@@ -135,10 +150,11 @@ setenv() {
 		info "-----------------------------------------------------------------"
 		# TODO we should call here switch-to-configuration as well to use single
 		# sudo session and remove one prompt.
-		_ssh "$device" \
-			sudo sh -c \
-				'nix-env --profile /nix/var/nix/profiles/system --set "$store" && /nix/var/nix/profiles/system/bin/switch-to-configuration "$1"' \
-					"$switchop"
+		local _store _switchop
+		printf -v _store '%q' "$store"
+		printf -v _switchop '%q' "$switchop"
+		_tssh "$device" \
+			"sudo nix-env --profile /nix/var/nix/profiles/system --set '$_store' && sudo /nix/var/nix/profiles/system/bin/switch-to-configuration '$_switchop'"
 	else
 		warning "The latest system might have been already set."
 	fi
-- 
cgit v1.2.3